Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/string-breakpoints #191

Merged
merged 2 commits into from Jul 18, 2021
Merged

Feat/string-breakpoints #191

merged 2 commits into from Jul 18, 2021

Conversation

chandelieraxel
Copy link
Contributor

@chandelieraxel chandelieraxel commented Jul 17, 2021 •
edited by damassi

Closes #170

Hi ! This is my first time contributing to an open source project, I hope you don't mind me !

This pull request is to handle the issues reported here : #170, in order to be able to give strings as values on the breakpoints

@damassi
Copy link
Member

damassi commented Jul 18, 2021

Great first contribution @Spartakyste - looks great 👍

@damassi
Copy link
Member

damassi commented Jul 18, 2021

cc @erikdstock

@damassi damassi merged commit 2da400d into artsy:master Jul 18, 2021
@artsyit
Copy link
Contributor

artsyit commented Jul 18, 2021

🚀 PR was released in v1.8.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Version: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept string breakpoint values
3 participants
@chandelieraxel @damassi @artsyit